From 4346620afaa8087e129673101bcd84f4100556da Mon Sep 17 00:00:00 2001 From: Bartosz Taudul Date: Thu, 27 Feb 2020 13:45:39 +0100 Subject: [PATCH] No need to copy module name. --- client/TracyCallstack.cpp | 6 +++--- client/TracyProfiler.cpp | 2 -- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/client/TracyCallstack.cpp b/client/TracyCallstack.cpp index d6a6b78f..236732b8 100644 --- a/client/TracyCallstack.cpp +++ b/client/TracyCallstack.cpp @@ -317,7 +317,7 @@ CallstackEntryData DecodeCallstackPtr( uint64_t ptr ) } #endif - return { cb_data, uint8_t( cb_num ), CopyString( moduleName ) }; + return { cb_data, uint8_t( cb_num ), moduleName }; } #elif TRACY_HAS_CALLSTACK == 2 || TRACY_HAS_CALLSTACK == 3 || TRACY_HAS_CALLSTACK == 4 || TRACY_HAS_CALLSTACK == 6 @@ -548,7 +548,7 @@ CallstackEntryData DecodeCallstackPtr( uint64_t ptr ) Dl_info dlinfo; if( dladdr( (void*)ptr, &dlinfo ) ) symloc = dlinfo.dli_fname; - return { cb_data, uint8_t( cb_num ), CopyString( symloc ? symloc : "[unknown]" ) }; + return { cb_data, uint8_t( cb_num ), symloc ? symloc : "[unknown]" }; } #elif TRACY_HAS_CALLSTACK == 5 @@ -651,7 +651,7 @@ CallstackEntryData DecodeCallstackPtr( uint64_t ptr ) if( demangled ) free( demangled ); - return { &cb, 1, CopyString( symloc ? symloc : "[unknown]" ) }; + return { &cb, 1, symloc }; } #endif diff --git a/client/TracyProfiler.cpp b/client/TracyProfiler.cpp index 0e9a36e1..a8f99911 100644 --- a/client/TracyProfiler.cpp +++ b/client/TracyProfiler.cpp @@ -2224,8 +2224,6 @@ void Profiler::SendCallstackFrame( uint64_t ptr ) MemWrite( &item.callstackFrameSize.imageName, (uint64_t)frameData.imageName ); AppendData( &item, QueueDataSize[(int)QueueType::CallstackFrameSize] ); - - tracy_free( (void*)frameData.imageName ); } for( uint8_t i=0; i